linux-kernel - Re: [PATCH v5 1/1] i3c: master: Remove i3c_dev_disable_ibi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173041558585.2392356.5423028675808780456.b4-ty@bootlin.com>
Date: Fri, 1 Nov 2024 00:00:05 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: miquel.raynal@...tlin.com, Frank Li <Frank.Li@....com>
Cc: Frank.li@....com, arnd@...db.de, bbrezillon@...nel.org,
	boris.brezillon@...labora.com, conor.culhane@...vaco.com,
	gregkh@...uxfoundation.org, imx@...ts.linux.dev,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
	pthombar@...ence.com, ravindra.yashvant.shinde@....com,
	stable@...nel.org
Subject: Re: [PATCH v5 1/1] i3c: master: Remove
 i3c_dev_disable_ibi_locked(olddev) on device hotjoin

On Tue, 01 Oct 2024 12:22:32 -0400, Frank Li wrote:
> When a new device hotjoins, a new dynamic address is assigned.
> i3c_master_add_i3c_dev_locked() identifies that the device was previously
> attached to the bus and locates the olddev.
> 
> i3c_master_add_i3c_dev_locked()
> {
>     ...
>     olddev = i3c_master_search_i3c_dev_duplicate(newdev);
>     ...
>     if (olddev) {
>         ...
>         i3c_dev_disable_ibi_locked(olddev);
>         ^^^^^^
>         The olddev should not receive any commands on the i3c bus as it
>         does not exist and has been assigned a new address. This will
>         result in NACK or timeout. So remove it.
>     }
> 
> [...]

Applied, thanks!

[1/1] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin
      https://git.kernel.org/abelloni/c/36faa04ce3d9

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com