linux-kernel - Re: [PATCH] trace/events/page_ref: add page info to page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyL__1ClDcInaen9@casper.infradead.org>
Date: Thu, 31 Oct 2024 03:56:47 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Kassey Li <quic_yingangl@...cinc.com>
Cc: akpm@...ux-foundation.org, vbabka@...nel.org, minchan@...nel.org,
	vbabka@...e.cz, iamjoonsoo.kim@....com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace
 event

On Thu, Oct 31, 2024 at 10:42:22AM +0800, Kassey Li wrote:
> This followed
> commit 53d884a6675b ("mm, tracing: unify PFN format strings")
> to add page info.
> 
> In many kernel code we are talking with page other than pfn,
> here we added page algin with pfn.

It's generally a bad idea to print pointers to kernel memory, so no I
don't like this patch.