[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241031040952.109057-1-mario.limonciello@amd.com>
Date: Wed, 30 Oct 2024 23:09:30 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Hans de Goede <hdegoede@...hat.com>, Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com>
CC: "Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
Maximilian Luz <luzmaximilian@...il.com>, Lee Chun-Yi <jlee@...e.com>, "Shyam
Sundar S K" <Shyam-sundar.S-k@....com>, Corentin Chary
<corentin.chary@...il.com>, "Luke D . Jones" <luke@...nes.dev>, Ike Panhc
<ike.pan@...onical.com>, Henrique de Moraes Holschuh <hmh@....eng.br>,
"Alexis Belmonte" <alexbelm48@...il.com>, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Ai Chao <aichao@...inos.cn>, Gergo Koteles
<soyer@....hu>, open list <linux-kernel@...r.kernel.org>, "open list:ACPI"
<linux-acpi@...r.kernel.org>, "open list:MICROSOFT SURFACE PLATFORM PROFILE
DRIVER" <platform-driver-x86@...r.kernel.org>, "open list:THINKPAD ACPI
EXTRAS DRIVER" <ibm-acpi-devel@...ts.sourceforge.net>, Mark Pearson
<mpearson-lenovo@...ebb.ca>, Matthew Schwartz <matthew.schwartz@...ux.dev>,
Mario Limonciello <mario.limonciello@....com>
Subject: [PATCH v3 00/22] Add support for binding ACPI platform profile to multiple drivers
Currently there are a number of ASUS products on the market that happen to
have ACPI objects for amd-pmf to bind to as well as an ACPI platform profile
provided by asus-wmi.
The ACPI platform profile support created by amd-pmf on these ASUS products is "Function 9"
which is specifically for "BIOS or EC notification" of power slider position.
This feature is actively used by some designs such as Framework 13 and Framework 16.
On these ASUS designs we keep on quirking more and more of them to turn off this
notification so that asus-wmi can bind.
This however isn't how Windows works. "Multiple" things are notified for the power
slider position. This series adjusts Linux to behave similarly.
Multiple drivers can now register an ACPI platform profile and will react to set requests.
To avoid chaos, only positions that are common to both drivers are accepted
when the legacy /sys/firmware/acpi/platform_profile interface is used.
This series also adds a new concept of a "custom" profile. This allows userspace
to discover that there are multiple driver handlers that are configured differently.
This series also allows dropping all of the PMF quirks from amd-pmf.
v3:
* Split to even more patches
* Add concept of class device for platform profile handlers
* Add concept of custom profile for legacy sysfs interface
* Pick up tags for some patches
v2:
* Split to many more patches
* Account for feedback from M/L
Mario Limonciello (22):
ACPI: platform-profile: Add a name member to handlers
platform/x86/dell: dell-pc: Create platform device
ACPI: platform_profile: Add device pointer into platform profile
handler
ACPI: platform_profile: Add platform handler argument to
platform_profile_remove()
ACPI: platform_profile: Add a list to platform profile handler
ACPI: platform_profile: Move sanity check out of the mutex
ACPI: platform_profile: Use guard(mutex) for register/unregister
ACPI: platform_profile: Use `scoped_cond_guard` for
platform_profile_choices_show()
ACPI: platform_profile: Use `scoped_cond_guard` for
platform_profile_show()
ACPI: platform_profile: Use `scoped_cond_guard` for
platform_profile_show()
ACPI: platform_profile: Use `scoped_cond_guard` for
platform_profile_cycle()
ACPI: platform_profile: Only remove group when no more handler
registered
ACPI: platform_profile: Require handlers to support balanced profile
ACPI: platform_profile: Notify change events on register and
unregister
ACPI: platform_profile: Only show profiles common for all handlers
ACPI: platform_profile: Set profile for all registered handlers
ACPI: platform_profile: Add concept of a "custom" profile
ACPI: platform_profile: Make sure all profile handlers agree on
profile
ACPI: platform_profile: Check all profile handler to calculate next
ACPI: platform_profile: Register class device for platform profile
handlers
ACPI: platform_profile: Allow multiple handlers
platform/x86/amd: pmf: Drop all quirks
drivers/acpi/platform_profile.c | 330 ++++++++++++------
.../surface/surface_platform_profile.c | 8 +-
drivers/platform/x86/acer-wmi.c | 10 +-
drivers/platform/x86/amd/pmf/Makefile | 2 +-
drivers/platform/x86/amd/pmf/core.c | 1 -
drivers/platform/x86/amd/pmf/pmf-quirks.c | 66 ----
drivers/platform/x86/amd/pmf/pmf.h | 3 -
drivers/platform/x86/amd/pmf/sps.c | 4 +-
drivers/platform/x86/asus-wmi.c | 6 +-
drivers/platform/x86/dell/dell-pc.c | 39 ++-
drivers/platform/x86/hp/hp-wmi.c | 8 +-
drivers/platform/x86/ideapad-laptop.c | 4 +-
.../platform/x86/inspur_platform_profile.c | 7 +-
drivers/platform/x86/thinkpad_acpi.c | 4 +-
include/linux/platform_profile.h | 8 +-
15 files changed, 303 insertions(+), 197 deletions(-)
delete mode 100644 drivers/platform/x86/amd/pmf/pmf-quirks.c
--
2.43.0
Powered by blists - more mailing lists