linux-kernel - RE: [PATCH v3 06/10] x86/mce: Break up __mcheck_cpu_apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71347AF10C3ED8FBAACED62C89552@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Thu, 31 Oct 2024 05:18:54 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "bp@...en8.de" <bp@...en8.de>
CC: "Luck, Tony" <tony.luck@...el.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 06/10] x86/mce: Break up __mcheck_cpu_apply_quirks()

Hi Yazen,

> From: Yazen Ghannam <yazen.ghannam@....com>
> [...]
> > Just from my perspective, no strong preference. 😊
> 
> Same here. I just figured this suggestion would be another possible
> cleanup. :)

Thanks for your suggestion. Yes, it does save 3 lines of code.
Either the current patch or your suggestion is OK with me.

Hi @Boris, 
may I know which option is OK with you:

    Option A (current patch): 
                    struct mca_config *cfg = &mca_cfg;
                    and then use 'cfg' in apply_quirks_{amd, intel, zhaoxin}()

    Option B (suggested by Yazen):
                    Directly use 'mca_cfg' in apply_quirks_{amd, intel, zhaoxin}()

Thanks!
-Qiuxu