linux-kernel - Re: [PATCH RFC net-next v2 05/18] net: pse-pd: Add support for PSE device index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyMjbzK7SJq5nmYz@pengutronix.de>
Date: Thu, 31 Oct 2024 07:27:59 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Donald Hunter <donald.hunter@...il.com>,
	Rob Herring <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	Simon Horman <horms@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>,
	Dent Project <dentproject@...uxfoundation.org>,
	kernel@...gutronix.de,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH RFC net-next v2 05/18] net: pse-pd: Add support for PSE
 device index

On Wed, Oct 30, 2024 at 05:53:07PM +0100, Kory Maincent wrote:

...
>  /**
>   * struct pse_control - a PSE control
> @@ -440,18 +441,22 @@ int pse_controller_register(struct pse_controller_dev *pcdev)
>  
>  	mutex_init(&pcdev->lock);
>  	INIT_LIST_HEAD(&pcdev->pse_control_head);
> +	ret = ida_alloc_max(&pse_ida, INT_MAX, GFP_KERNEL);

s/INT_MAX/U32_MAX

...
>  struct pse_control_status {
> +	u32 pse_id;
>  	enum ethtool_podl_pse_admin_state podl_admin_state;
...
>  struct pse_controller_dev {
>  	const struct pse_controller_ops *ops;
> @@ -163,6 +166,7 @@ struct pse_controller_dev {
>  	enum ethtool_pse_types types;
>  	struct pse_pi *pi;
>  	bool no_of_pse_pi;
> +	int id;

        u32 id

It would be better to have one type for all variables.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |