linux-kernel - Re: [PATCH] perf, riscv: Wire up perf trace support for RISC-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyMmD1SdqpIg8Wox@google.com>
Date: Wed, 30 Oct 2024 23:39:11 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Alexandre Ghiti <alex@...ti.fr>
Cc: Björn Töpel <bjorn@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	Björn Töpel <bjorn@...osinc.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Anup Patel <anup@...infault.org>,
	Atish Patra <atishp@...osinc.com>
Subject: Re: [PATCH] perf, riscv: Wire up perf trace support for RISC-V

Hello,

On Wed, Oct 30, 2024 at 08:31:35AM +0100, Alexandre Ghiti wrote:
> Hi Bjorn, Namhyung,
> 
> On 30/10/2024 01:37, Namhyung Kim wrote:
> > Hello,
> > 
> > On Thu, Oct 24, 2024 at 12:03:51PM -0700, Björn Töpel wrote:
> > > From: Björn Töpel <bjorn@...osinc.com>
> > > 
> > > RISC-V does not currently support perf trace, since the system call
> > > table is not generated.
> > > 
> > > Perform the copy/paste exercise, wiring up RISC-V system call table
> > > generation.
> > Can anybody with RISC-V please test this?
> 
> 
> So before this patch, I get:
> 
> Error::5File /sys/kernel/tracing//events/raw_syscalls/sys_(enter|exit) not
> found.
> Hint:    Perhaps this kernel misses some CONFIG_ setting to enable this
> feature?.
> 
> After applying this patch, I get a proper trace:
> ....
> 
>      7.435 ( 0.332 ms): ls/1307 openat(dfd: CWD, filename: 0xb36ef668,
> flags: RDONLY|CLOEXEC)         = 3
>      8.023 ( 0.454 ms): ls/1307 mmap(len: 23171, prot: READ, flags: PRIVATE,
> fd: 3)                   = 0x7fffb36cd000
>      8.558 ( 0.065 ms): ls/1307 close(fd:
> 3)                                                          = 0
>      8.850 ( 0.294 ms): ls/1307 openat(dfd: CWD, filename: 0xb36f9f80,
> flags: RDONLY|CLOEXEC)         = 3
>      9.223 ( 0.152 ms): ls/1307 read(fd: 3, buf: 0x7fffe27b3c20, count: 832)
> 
> ...
> 
> So you can add:
> 
> Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks for your test!
Namhyung