linux-kernel - Re: [PATCH v1 1/1] PCI/bwctrl: Check for error code from devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyMrOiW82OKcBMEi@smile.fi.intel.com>
Date: Thu, 31 Oct 2024 09:01:14 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] PCI/bwctrl: Check for error code from
 devm_mutex_init() call

On Wed, Oct 30, 2024 at 01:09:21PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 30, 2024 at 06:31:39PM +0200, Andy Shevchenko wrote:
> > Even if it's not critical, the avoidance of checking the error code
> > from devm_mutex_init() call today diminishes the point of using devm
> > variant of it. Tomorrow it may even leak something. Add the missed
> > check.
> > 
> > Fixes: 9b3da6e19e4d ("PCI/bwctrl: Add pcie_set_target_speed() to set PCIe Link Speed")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Squashed into 399ba413fa23 ("PCI/bwctrl: Add pcie_set_target_speed()
> to set PCIe Link Speed"), thanks, Andy.

Thanks, that works for me!

-- 
With Best Regards,
Andy Shevchenko