linux-kernel - Re: [PATCH V4 0/4] Add support for QCOM SPMI PMIC5 Gen3 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2c2zxxmsk74rbgbhus7nyrxppwdeq2esgifigt7c326zzlmla@6vdb2rmbjptl>
Date: Thu, 31 Oct 2024 08:36:43 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jishnu Prakash <quic_jprakash@...cinc.com>
Cc: jic23@...nel.org, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, agross@...nel.org, andersson@...nel.org, 
	dmitry.baryshkov@...aro.org, konrad.dybcio@...aro.org, daniel.lezcano@...aro.org, 
	sboyd@...nel.org, quic_subbaram@...cinc.com, quic_collinsd@...cinc.com, 
	quic_amelende@...cinc.com, quic_kamalw@...cinc.com, amitk@...nel.org, lee@...nel.org, 
	rafael@...nel.org, rui.zhang@...el.com, lukasz.luba@....com, lars@...afoo.de, 
	quic_skakitap@...cinc.com, neil.armstrong@...aro.org, devicetree@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, cros-qcom-dts-watchers@...omium.org
Subject: Re: [PATCH V4 0/4] Add support for QCOM SPMI PMIC5 Gen3 ADC

On Thu, Oct 31, 2024 at 12:28:50AM +0530, Jishnu Prakash wrote:
> PMIC5 Gen3 has a similar ADC architecture to that on PMIC5 Gen2,
> with all SW communication to ADC going through PMK8550 which
> communicates with other PMICs through PBS. The major difference is
> that the register interface used here is that of an SDAM present on
> PMK8550, rather than a dedicated ADC peripheral. There may be more than one
> SDAM used for ADC5 Gen3. Each ADC SDAM has eight channels, each of which may
> be used for either immediate reads (same functionality as previous PMIC5 and
> PMIC5 Gen2 ADC peripherals) or recurring measurements (same as PMIC5 and PMIC5
> Gen2 ADC_TM functionality). In this case, we have VADC and ADC_TM functionality
> combined into the same driver.
> 
> Patch 1 is a cleanup, to move the QCOM ADC dt-bindings files from
> dt-bindings/iio to dt-bindings/iio/adc folder, as they are
> specifically for ADC devices. It also fixes all compilation errors
> with this change in driver and devicetree files and similar errors
> in documentation for dtbinding check.
> 
> Patch 2 adds bindings for ADC5 Gen3 peripheral.
> 
> Patch 3 adds the main driver for ADC5 Gen3.
> 
> Patch 4 adds the auxiliary thermal driver which supports the ADC_TM
> functionality of ADC5 Gen3.
> 
> Changes since v3:
> - Updated files affected by adc file path change in /arch/arm folder,
>   which were missed earlier.

I don't think this was tested afterwards...

Best regards,
Krzysztof