linux-kernel - Re: [PATCH] bcachefs: Correct the description of the '--bucket=size' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da24a338-72ba-4148-be01-359d740a5aba@linux.dev>
Date: Thu, 31 Oct 2024 16:05:44 +0800
From: Youling Tang <youling.tang@...ux.dev>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org,
 Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] bcachefs: Correct the description of the '--bucket=size'
 options

Hi, Kent

Give you a friendly ping. 🙂

BTW, is the following patch needed?
[1] 
https://lore.kernel.org/linux-bcachefs/20240709011134.79954-1-youling.tang@linux.dev/
[2] 
https://lore.kernel.org/linux-bcachefs/20240924025350.3948674-1-youling.tang@linux.dev/
[3] 
https://lore.kernel.org/linux-bcachefs/20240927084042.1516361-1-youling.tang@linux.dev/
[4] 
https://lore.kernel.org/linux-bcachefs/20241016014911.1555607-1-youling.tang@linux.dev/

Thanks,
Youling.

On 2024/10/16 09:50, Youling Tang wrote:
> From: Youling Tang <tangyouling@...inos.cn>
>
> Signed-off-by: Youling Tang <tangyouling@...inos.cn>
> ---
>   fs/bcachefs/opts.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/opts.h b/fs/bcachefs/opts.h
> index cb2e244a2429..92eae5636f2b 100644
> --- a/fs/bcachefs/opts.h
> +++ b/fs/bcachefs/opts.h
> @@ -487,7 +487,7 @@ enum fsck_err_opts {
>   	  OPT_DEVICE,							\
>   	  OPT_UINT(0, S64_MAX),						\
>   	  BCH2_NO_SB_OPT,		0,				\
> -	  "size",	"Size of filesystem on device")			\
> +	  "size",	"Specifies the bucket size; must be greater than the btree node size")\
>   	x(durability,			u8,				\
>   	  OPT_DEVICE|OPT_SB_FIELD_ONE_BIAS,				\
>   	  OPT_UINT(0, BCH_REPLICAS_MAX),				\