linux-kernel - RE: [PATCH 02/16] x86/amd_nb: Restrict init function to AMD-based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71340D079448528FD548F73289552@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Thu, 31 Oct 2024 08:09:14 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Luck,
 Tony" <tony.luck@...el.com>, "x86@...nel.org" <x86@...nel.org>,
	"avadhut.naik@....com" <avadhut.naik@....com>, "john.allen@....com"
	<john.allen@....com>, "mario.limonciello@....com"
	<mario.limonciello@....com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"Shyam-sundar.S-k@....com" <Shyam-sundar.S-k@....com>, "richard.gong@....com"
	<richard.gong@....com>, "jdelvare@...e.com" <jdelvare@...e.com>,
	"linux@...ck-us.net" <linux@...ck-us.net>, "clemens@...isch.de"
	<clemens@...isch.de>, "hdegoede@...hat.com" <hdegoede@...hat.com>,
	"ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	"naveenkrishna.chatradhi@....com" <naveenkrishna.chatradhi@....com>,
	"carlos.bilbao.osdev@...il.com" <carlos.bilbao.osdev@...il.com>
Subject: RE: [PATCH 02/16] x86/amd_nb: Restrict init function to AMD-based
 systems

> From: Yazen Ghannam <yazen.ghannam@....com>
> [..]
> --- a/arch/x86/kernel/amd_nb.c
> +++ b/arch/x86/kernel/amd_nb.c
> @@ -582,6 +582,10 @@ static __init void fix_erratum_688(void)
> 
>  static __init int init_amd_nbs(void)
>  {
> +	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD &&
> +	    boot_cpu_data.x86_vendor != X86_VENDOR_HYGON)
> +		return 0;
> +
>  	amd_cache_northbridges();

This function could fail and return an error.
Is an early return with an error code needed if this function fails?

[ I know this is out of this patch scope. ]

>  	amd_cache_gart();

-Qiuxu