[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87jzdoadve.fsf@BLaptop.bootlin.com>
Date: Thu, 31 Oct 2024 09:13:57 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Jiaxun Yang <jiaxun.yang@...goat.com>, Aleksandar Rikalo
<arikalo@...il.com>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Vladimir Kondratiev
<vladimir.kondratiev@...ileye.com>, Theo Lebrun <theo.lebrun@...tlin.com>,
Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org, Djordje
Todorovic <djordje.todorovic@...cgroup.com>, Chao-ying Fu
<cfu@...ecomp.com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Geert
Uytterhoeven <geert@...ux-m68k.org>, Greg Ungerer <gerg@...nel.org>, Hauke
Mehrtens <hauke@...ke-m.de>, Ilya Lipnitskiy <ilya.lipnitskiy@...il.com>,
linux-kernel@...r.kernel.org, "linux-mips@...r.kernel.org"
<linux-mips@...r.kernel.org>, Marc Zyngier <maz@...nel.org>,
"paulburton@...nel.org" <paulburton@...nel.org>, Peter Zijlstra
<peterz@...radead.org>, Serge Semin <fancer.lancer@...il.com>, Tiezhu Yang
<yangtiezhu@...ngson.cn>
Subject: Re: [PATCH v8 10/13] dt-bindings: mips: cpu: Add property for
broken HCI information
Hi Jiaxun,
> 在2024年10月29日十月 下午4:11,Jiaxun Yang写道:
>> 在2024年10月29日十月 下午12:21,Aleksandar Rikalo写道:
>> [...]
>>>
>>>> Is this property applicable for all MIPS vendors? There is no vendor
>>>> prefix here, so this is generic for this architecture, right?
>>
>> I'd say the best vendor prefix is mti in this case.
>>
>> CM3 IP block is supplied by MIPS Technology, it is not a part of MIPS
>> architecture spec.
>
> I just tried to revise this problem and I think a better approach would
> be picking my CM binding [1] patch and add this as a property to CM binding.
>
> You don't need to pick rest of that series, this binding alone is sufficient,
> and it's already being reviewed.
>
> Thanks
> [1]:
> https://lore.kernel.org/all/20240612-cm_probe-v2-5-a5b55440563c@flygoat.com/
I had a look at your series and it seems that all the issues raised were
solved, so why wasn't it merged?
Regarding the binding in particular: If we add the property
"cm3-l2-config-hci-broken", then it should be optional. However, the reg
property also should be optional. Indeed, if we can detect the CM
address, we shouldn't use a reg property.
If we go in this direction, not only will the binding be modified but
also code in arch/mips/kernel/mips-cm.c to handle this new property and
manage the case where the reg is not needed. Additionally, we'll need to
modify code in arch/mips/kernel/smp-cps.c to retrieve information about
the HCI.
I can write a series to illustrate it, if needed.
Gregory
>>
>> Thanks
>> --
>> - Jiaxun
>
> --
> - Jiaxun
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists