linux-kernel - Re: [PATCH v2] mm: define general function pXd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <836c4d86-3b93-06fc-8ac1-6f636a244753@loongson.cn>
Date: Thu, 31 Oct 2024 09:08:13 +0800
From: maobibo <maobibo@...ngson.cn>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Huacai Chen <chenhuacai@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Andrey Ryabinin <ryabinin.a.a@...il.com>, loongarch@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
 linux-mm@...ck.org, kasan-dev@...glegroups.com,
 Alexander Potapenko <glider@...gle.com>,
 Andrey Konovalov <andreyknvl@...il.com>, Dmitry Vyukov <dvyukov@...gle.com>,
 Vincenzo Frascino <vincenzo.frascino@....com>,
 WANG Xuerui <kernel@...0n.name>
Subject: Re: [PATCH v2] mm: define general function pXd_init()



On 2024/10/31 上午7:41, Andrew Morton wrote:
> On Wed, 30 Oct 2024 14:39:05 +0800 Bibo Mao <maobibo@...ngson.cn> wrote:
> 
>> --- a/arch/loongarch/include/asm/pgtable.h
>> +++ b/arch/loongarch/include/asm/pgtable.h
>> @@ -267,8 +267,11 @@ extern void set_pmd_at(struct mm_struct *mm, unsigned long addr, pmd_t *pmdp, pm
>>    * Initialize a new pgd / pud / pmd table with invalid pointers.
>>    */
>>   extern void pgd_init(void *addr);
>> +#define pud_init pud_init
>>   extern void pud_init(void *addr);
>> +#define pmd_init pmd_init
>>   extern void pmd_init(void *addr);
>> +#define kernel_pte_init kernel_pte_init
>>   extern void kernel_pte_init(void *addr);
> 
> Nitlet: don't we usually put the #define *after* the definition?
> 
> void foo(void);
> #define foo() foo()
yes, it should be so. Will modify it in next version.

Regards
Bibo Mao
> 
> ?
> 
>