linux-kernel - Re: [PATCH 4/6] dt-bindings: input: matrix_keypad - add settle time after enable all columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <all3yq7g2ovuiszbjnmvmnyimx4fdrpecnef5si366o72vmwtk@psffqupomzgz>
Date: Thu, 31 Oct 2024 09:32:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Markus Burri <markus.burri@...com>
Cc: linux-kernel@...r.kernel.org, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-input@...r.kernel.org, 
	devicetree@...r.kernel.org, Manuel Traut <manuel.traut@...com>, 
	HeDong Zhao <hedong.zhao@...com>
Subject: Re: [PATCH 4/6] dt-bindings: input: matrix_keypad - add settle time
 after enable all columns

On Thu, Oct 31, 2024 at 07:30:02AM +0100, Markus Burri wrote:
> Matrix_keypad with high capacity need a longer settle time after enable
> all columns.
> Add optional property to specify the settle time
> 
> Signed-off-by: Markus Burri <markus.burri@...com>
> Reviewed-by: Manuel Traut <manuel.traut@...com>
> Tested-by: HeDong Zhao <hedong.zhao@...com>

How was a TXT binding tested?

Both tags look fake, where were they given?

> ---
>  Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> index 570dc10..cf43fa0 100644
> --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> @@ -24,6 +24,8 @@ Optional Properties:
>  - debounce-delay-ms:	debounce interval in milliseconds
>  - col-scan-delay-us:	delay, measured in microseconds, that is needed
>  			before we can scan keypad after activating column gpio
> +- all-cols-on-delay-us:	delay, measured in microseconds, that is needed
> +			after activating all column gpios, default is no delay.

Binding should be converted to DT schema first.

Best regards,
Krzysztof