linux-kernel - RE: [PATCH] phy: starfive: jh7110-dphy-tx: Add missing clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <NTZPR01MB10503E5B049DA0F2E9B33CAAEE552@NTZPR01MB1050.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 31 Oct 2024 07:51:05 +0000
From: Keith Zhao <keith.zhao@...rfivetech.com>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>, Vinod Koul
	<vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>
CC: Dan Carpenter <dan.carpenter@...aro.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] phy: starfive: jh7110-dphy-tx: Add missing
 clk_disable_unprepare()



> -----Original Message-----
> From: Changhuang Liang <changhuang.liang@...rfivetech.com>
> Sent: 2024年10月31日 15:34
> To: Vinod Koul <vkoul@...nel.org>; Kishon Vijay Abraham I <kishon@...nel.org>
> Cc: Keith Zhao <keith.zhao@...rfivetech.com>; Changhuang Liang
> <changhuang.liang@...rfivetech.com>; Dan Carpenter
> <dan.carpenter@...aro.org>; linux-phy@...ts.infradead.org;
> linux-kernel@...r.kernel.org
> Subject: [PATCH] phy: starfive: jh7110-dphy-tx: Add missing
> clk_disable_unprepare()
> 
> Once the reset_control_deassert() fails, we need to run the missing
> clk_disable_unprepare() before return in stf_dphy_init().
> 
> Fixes: d3ab79553308 ("phy: starfive: Add mipi dphy tx support")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202410310715.duo3ShR4-lkp@intel.com/
> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>

Reviewed-by: Keith Zhao <keith.zhao@...rfivetech.com>

> ---
>  drivers/phy/starfive/phy-jh7110-dphy-tx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/starfive/phy-jh7110-dphy-tx.c
> b/drivers/phy/starfive/phy-jh7110-dphy-tx.c
> index c64d1c91b130..7b59496983d2 100644
> --- a/drivers/phy/starfive/phy-jh7110-dphy-tx.c
> +++ b/drivers/phy/starfive/phy-jh7110-dphy-tx.c
> @@ -330,6 +330,7 @@ static int stf_dphy_init(struct phy *phy)
> 
>  	ret = reset_control_deassert(dphy->sys_rst);
>  	if (ret) {
> +		clk_disable_unprepare(dphy->txesc_clk);
>  		dev_err(dphy->dev, "Failed to deassert sys_rst\n");
>  		return ret;
>  	}
> --
> 2.25.1