[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <63acd502-bee4-ab00-1446-0f76686737ef@linux.intel.com>
Date: Thu, 31 Oct 2024 12:16:24 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mario Limonciello <mario.limonciello@....com>
cc: Hans de Goede <hdegoede@...hat.com>,
"Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
Maximilian Luz <luzmaximilian@...il.com>, Lee Chun-Yi <jlee@...e.com>,
Shyam Sundar S K <Shyam-sundar.S-k@....com>,
Corentin Chary <corentin.chary@...il.com>,
"Luke D . Jones" <luke@...nes.dev>, Ike Panhc <ike.pan@...onical.com>,
Henrique de Moraes Holschuh <hmh@....eng.br>,
Alexis Belmonte <alexbelm48@...il.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Ai Chao <aichao@...inos.cn>, Gergo Koteles <soyer@....hu>,
open list <linux-kernel@...r.kernel.org>,
"open list:ACPI" <linux-acpi@...r.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER" <platform-driver-x86@...r.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER" <ibm-acpi-devel@...ts.sourceforge.net>,
Mark Pearson <mpearson-lenovo@...ebb.ca>,
Matthew Schwartz <matthew.schwartz@...ux.dev>
Subject: Re: [PATCH v3 07/22] ACPI: platform_profile: Use guard(mutex) for
register/unregister
On Wed, 30 Oct 2024, Mario Limonciello wrote:
> guard(mutex) can be used to automatically release mutexes when going
> out of scope.
>
> Tested-by: Matthew Schwartz <matthew.schwartz@...ux.dev>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> drivers/acpi/platform_profile.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index f2f2274e4d83e..cc2037147c0fd 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -191,34 +191,29 @@ int platform_profile_register(struct platform_profile_handler *pprof)
> return -EINVAL;
> }
>
> - mutex_lock(&profile_lock);
> + guard(mutex)(&profile_lock);
> /* We can only have one active profile */
> - if (cur_profile) {
> - mutex_unlock(&profile_lock);
> + if (cur_profile)
> return -EEXIST;
> - }
>
> err = sysfs_create_group(acpi_kobj, &platform_profile_group);
> - if (err) {
> - mutex_unlock(&profile_lock);
> + if (err)
> return err;
> - }
> list_add_tail(&pprof->list, &platform_profile_handler_list);
>
> cur_profile = pprof;
> - mutex_unlock(&profile_lock);
> return 0;
> }
> EXPORT_SYMBOL_GPL(platform_profile_register);
>
> int platform_profile_remove(struct platform_profile_handler *pprof)
> {
> + guard(mutex)(&profile_lock);
> +
> list_del(&pprof->list);
>
> sysfs_remove_group(acpi_kobj, &platform_profile_group);
> - mutex_lock(&profile_lock);
> cur_profile = NULL;
> - mutex_unlock(&profile_lock);
> return 0;
> }
> EXPORT_SYMBOL_GPL(platform_profile_remove);
>
For patches 1-7,
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
--
i.
Powered by blists - more mailing lists