linux-kernel - Re: [PATCH 11/11] x86/cpu: Make all all CPUID leaf names consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241031101834.GGZyNZejzr5A9bNL8J@fat_crate.local>
Date: Thu, 31 Oct 2024 11:18:34 +0100
From: Borislav Petkov <bp@...en8.de>
To: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
	rafael@...nel.org, lenb@...nel.org
Subject: Re: [PATCH 11/11] x86/cpu: Make all all CPUID leaf names consistent

On Wed, Oct 30, 2024 at 02:33:29PM -0700, Dave Hansen wrote:
> diff -puN arch/x86/include/asm/cpuid.h~xsave-leaf-checks-3 arch/x86/include/asm/cpuid.h
> --- a/arch/x86/include/asm/cpuid.h~xsave-leaf-checks-3	2024-10-30 12:26:59.222216332 -0700
> +++ b/arch/x86/include/asm/cpuid.h	2024-10-30 12:26:59.238216364 -0700
> @@ -19,12 +19,12 @@ enum cpuid_regs_idx {
>  	CPUID_EDX,
>  };
>  
> -#define CPUID_MWAIT_LEAF	0x5
> -#define CPUID_DCA_LEAF		0x9
> -#define XSTATE_CPUID		0x0d
> -#define CPUID_TSC_LEAF		0x15
> -#define CPUID_FREQ_LEAF		0x16
> -#define TILE_CPUID		0x1d
> +#define CPUID_LEAF_MWAIT	0x5
> +#define CPUID_LEAF_DCA		0x9
> +#define CPUID_LEAF_XSTATE	0x0d
> +#define CPUID_LEAF_TSC		0x15
> +#define CPUID_LEAF_FREQ		0x16
> +#define CPUID_LEAF_TILE		0x1d

... and just to confuse things even more, there's enum cpuid_leafs too which
start with the "CPUID_" prefix too.

Pfff.

I'd like to unify them and I *think* kvm_cpu_cap_mask() should be able to
stomach that (or fixed if not)...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette