linux-kernel - Re: [PATCH 02/16] x86/amd_nb: Restrict init function to AMD-based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241031103642.GCZyNdumQSdi76CA3w@fat_crate.local>
Date: Thu, 31 Oct 2024 11:36:42 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: Yazen Ghannam <yazen.ghannam@....com>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"avadhut.naik@....com" <avadhut.naik@....com>,
	"john.allen@....com" <john.allen@....com>,
	"mario.limonciello@....com" <mario.limonciello@....com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"Shyam-sundar.S-k@....com" <Shyam-sundar.S-k@....com>,
	"richard.gong@....com" <richard.gong@....com>,
	"jdelvare@...e.com" <jdelvare@...e.com>,
	"linux@...ck-us.net" <linux@...ck-us.net>,
	"clemens@...isch.de" <clemens@...isch.de>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	"naveenkrishna.chatradhi@....com" <naveenkrishna.chatradhi@....com>,
	"carlos.bilbao.osdev@...il.com" <carlos.bilbao.osdev@...il.com>
Subject: Re: [PATCH 02/16] x86/amd_nb: Restrict init function to AMD-based
 systems

On Thu, Oct 31, 2024 at 08:09:14AM +0000, Zhuo, Qiuxu wrote:
> This function could fail and return an error.
> Is an early return with an error code needed if this function fails?

No, grep for amd_northbridges.num checks in the code.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette