linux-kernel - Re: [PATCH] ACPI: processor: Move arch_init_invariance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410311924.XtRR5d9M-lkp@intel.com>
Date: Thu, 31 Oct 2024 19:47:05 +0800
From: kernel test robot <lkp@...el.com>
To: Mario Limonciello <superm1@...nel.org>,
	"Rafael J . Wysocki" <rafael@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Len Brown <lenb@...nel.org>,
	"Gautham R . Shenoy" <gautham.shenoy@....com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mario Limonciello <mario.limonciello@....com>,
	Ivan Shapovalov <intelfx@...elfx.name>,
	Oleksandr Natalenko <oleksandr@...alenko.name>
Subject: Re: [PATCH] ACPI: processor: Move arch_init_invariance_cppc() call
 later

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.12-rc5 next-20241031]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-processor-Move-arch_init_invariance_cppc-call-later/20241030-015107
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20241029174910.600482-1-superm1%40kernel.org
patch subject: [PATCH] ACPI: processor: Move arch_init_invariance_cppc() call later
config: i386-randconfig-141-20241031 (https://download.01.org/0day-ci/archive/20241031/202410311924.XtRR5d9M-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241031/202410311924.XtRR5d9M-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410311924.XtRR5d9M-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/acpi/processor_driver.c:273:2: error: call to undeclared function 'arch_init_invariance_cppc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     273 |         arch_init_invariance_cppc();
         |         ^
   1 error generated.


vim +/arch_init_invariance_cppc +273 drivers/acpi/processor_driver.c

   239	
   240	/*
   241	 * We keep the driver loaded even when ACPI is not running.
   242	 * This is needed for the powernow-k8 driver, that works even without
   243	 * ACPI, but needs symbols from this driver
   244	 */
   245	static enum cpuhp_state hp_online;
   246	static int __init acpi_processor_driver_init(void)
   247	{
   248		int result = 0;
   249	
   250		if (acpi_disabled)
   251			return 0;
   252	
   253		if (!cpufreq_register_notifier(&acpi_processor_notifier_block,
   254					       CPUFREQ_POLICY_NOTIFIER)) {
   255			acpi_processor_cpufreq_init = true;
   256			acpi_processor_ignore_ppc_init();
   257		}
   258	
   259		result = driver_register(&acpi_processor_driver);
   260		if (result < 0)
   261			return result;
   262	
   263		result = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
   264					   "acpi/cpu-drv:online",
   265					   acpi_soft_cpu_online, NULL);
   266		if (result < 0)
   267			goto err;
   268		hp_online = result;
   269		cpuhp_setup_state_nocalls(CPUHP_ACPI_CPUDRV_DEAD, "acpi/cpu-drv:dead",
   270					  NULL, acpi_soft_cpu_dead);
   271	
   272		acpi_processor_throttling_init();
 > 273		arch_init_invariance_cppc();
   274		return 0;
   275	err:
   276		driver_unregister(&acpi_processor_driver);
   277		return result;
   278	}
   279	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki