[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ikt8wh8l.ffs@tglx>
Date: Thu, 31 Oct 2024 14:10:18 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Conor Dooley <conor@...nel.org>, Inochi Amaoto <inochiama@...il.com>
Cc: Conor Dooley <conor+dt@...nel.org>, Chen Wang
<unicorn_wang@...look.com>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
Peter Zijlstra <peterz@...radead.org>, Inochi Amaoto
<inochiama@...look.com>, Guo Ren <guoren@...nel.org>, Lad Prabhakar
<prabhakar.mahadev-lad.rj@...renesas.com>, Yangyu Chen <cyy@...self.name>,
Anup Patel <apatel@...tanamicro.com>, Hal Feng
<hal.feng@...rfivetech.com>, Geert Uytterhoeven <geert+renesas@...der.be>,
Yixun Lan <dlan@...too.org>, Longbin Li <looong.bin@...il.com>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Sophgo
SG2044 ACLINT SSWI
On Thu, Oct 31 2024 at 12:38, Conor Dooley wrote:
> On Thu, Oct 31, 2024 at 02:14:40PM +0800, Inochi Amaoto wrote:
>> On Thu, Oct 31, 2024 at 02:08:57PM +0800, Inochi Amaoto wrote:
>> > Sophgo SG2044 has a new version of T-HEAD C920, which implement
>> > a fully featured T-HEAD ACLINT device. This ACLINT device contains
>> > a SSWI device to support fast S-mode IPI.
>> >
>> > Add necessary compatible string for the T-HEAD ACLINT sswi device.
>> >
>> > Link: https://www.xrvm.com/product/xuantie/C920
>> > Signed-off-by: Inochi Amaoto <inochiama@...il.com>
>>
>> Hi, Conor,
>>
>> Could you review it again? I have updated the description of
>> the binding and mark the device is T-HEAD specific.
>
> Only thing I would say is that
> title: Sophgo sg2044 ACLINT Supervisor-level Software Interrupt Device
> should probably be
> title: T-Head c900 ACLINT Supervisor-level Software Interrupt Device
> or similar, since this isn't Sophgo's IP.
>
> w/ that,
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> (dunno if Thomas is willing to change that on application)
Yes
Powered by blists - more mailing lists