linux-kernel - Re: [PATCH] USB: serial: Fix use after free in debug printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyOEa9VuXVus79Ev@hovoldconsulting.com>
Date: Thu, 31 Oct 2024 14:21:47 +0100
From: Johan Hovold <johan@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] USB: serial: Fix use after free in debug printk

On Thu, Oct 31, 2024 at 12:39:10PM +0300, Dan Carpenter wrote:
> On Thu, Oct 31, 2024 at 12:35:31PM +0300, Dan Carpenter wrote:
> > On Thu, Oct 31, 2024 at 10:07:42AM +0100, Johan Hovold wrote:
> > > On Thu, Oct 31, 2024 at 09:59:10AM +0300, Dan Carpenter wrote:
> > > > The dev_dbg() call dereferences "urb" but it was already freed on the
> > > > previous line.  Move the debug output earlier in the function.
> > > 
> > > Thanks for catching this, but please use a temporary variable for the
> > > struct device pointer instead of changing the flow.
> > 
> > Why?  The output is the same either way and this way is cleaner code.
> 
> Nah, you're right.  A temporary variable is nicer.  It avoids having two if
> statements.

Yeah, and the debug printk belongs with the return.

v2 now applied, thanks.

Johan