linux-kernel - Re: [PATCH v1 1/3] mm/huge_memory: buddy allocator like folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <753EF6CA-C358-4D23-AC35-2ABBB61D0FC0@nvidia.com>
Date: Thu, 31 Oct 2024 10:04:31 -0400
From: Zi Yan <ziy@...dia.com>
To: "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>
Cc: linux-mm@...ck.org, "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Ryan Roberts <ryan.roberts@....com>, Hugh Dickins <hughd@...gle.com>,
 David Hildenbrand <david@...hat.com>, Yang Shi <yang@...amperecomputing.com>,
 Miaohe Lin <linmiaohe@...wei.com>, Kefeng Wang <wangkefeng.wang@...wei.com>,
 Yu Zhao <yuzhao@...gle.com>, John Hubbard <jhubbard@...dia.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] mm/huge_memory: buddy allocator like folio_split()

On 31 Oct 2024, at 6:14, Kirill A . Shutemov wrote:

> On Mon, Oct 28, 2024 at 02:09:30PM -0400, Zi Yan wrote:
>>  mm/huge_memory.c | 604 +++++++++++++++++++++++++++++------------------
>>  1 file changed, 372 insertions(+), 232 deletions(-)
>
> The patch is really hard to follow. Could you split it into multiple
> smaller patches?

How about these patches instead of this one?

1. add folio_split() backend code, including __folio_split_without_mapping() and __split_folio_to_order();
2. change split_huge_page_to_list_to_order() to use the backend code in 1;
3. add folio_split();
4. remove __split_huge_page() and __split_huge_page_tail().

Best Regards,
Yan, Zi