lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <173038380901.539202.10384642881814927293.kvalo@kernel.org>
Date: Thu, 31 Oct 2024 14:10:10 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: stas.yakovlev@...il.com, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
 Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] ipw2x00: fix bad alignments

Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:

> No functional modification involved.
> 
> ./drivers/net/wireless/intel/ipw2x00/libipw_rx.c:871:2-3: code aligned with following code on line 882.
> ./drivers/net/wireless/intel/ipw2x00/libipw_rx.c:886:2-3: code aligned with following code on line 900.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11381
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

It's cleaner to use '&&' operator than two if statements. Please also
add 'wifi: ' to subject.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241017020113.122029-1-jiapeng.chong@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ