linux-kernel - Re: [PATCH v3] ext4: prevent data-race that occur when read/write ext4_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173038521048.99135.17276287567851231611.b4-ty@mit.edu>
Date: Thu, 31 Oct 2024 10:33:37 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: adilger.kernel@...ger.ca, Jeongjun Park <aha310510@...il.com>
Cc: "Theodore Ts'o" <tytso@....edu>, akpm@...l.org, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] ext4: prevent data-race that occur when read/write ext4_group_desc structure members


On Thu, 03 Oct 2024 21:53:37 +0900, Jeongjun Park wrote:
> Currently, data-race like [1] occur in fs/ext4/ialloc.c
> 
> find_group_other() and find_group_orlov() read *_lo, *_hi with
> ext4_free_inodes_count without additional locking. This can cause data-race,
> but since the lock is held for most writes and free inodes value is generally
> not a problem even if it is incorrect, it is more appropriate to use
> READ_ONCE()/WRITE_ONCE() than to add locking.
> 
> [...]

Applied, thanks!

[1/1] ext4: prevent data-race that occur when read/write ext4_group_desc structure members
      commit: 902cc179c931a033cd7f4242353aa2733bf8524c

Best regards,
-- 
Theodore Ts'o <tytso@....edu>