linux-kernel - Re: [PATCH v2 00/19] hrtimers: Consolidate hrtimer initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241031143609.bX-WHDeK@linutronix.de>
Date: Thu, 31 Oct 2024 15:36:09 +0100
From: Nam Cao <namcao@...utronix.de>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>,
	Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org
Cc: Jani Nikula <jani.nikula@...ux.intel.com>,
	intel-gfx@...ts.freedesktop.org,
	Sean Christopherson <seanjc@...gle.com>,
	Paolo Bonzini <pbonzini@...hat.com>, x86@...nel.org,
	Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>,
	Jens Axboe <axboe@...nel.dk>,
	Christian Brauner <brauner@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	John Stultz <jstultz@...gle.com>,
	Oliver Hartkopp <socketcan@...tkopp.net>, kvm@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH v2 00/19] hrtimers: Consolidate hrtimer initialization -
 Part 1

I just learned the hard way that git-send-email doesn't work for a .mbox
file including multiple emails. Sorry for the noises, please ignore this
one. I will resend it shortly.

On Thu, Oct 31, 2024 at 03:19:21PM +0100, Nam Cao wrote:
> This is a follow up to version 1, which can be found here:
> 
>     https://lore.kernel.org/lkml/cover.1729864615.git.namcao@linutronix.de/
> 
> hrtimers must be initialized with a hrtimer_init() variant, and after that
> the timer's callback function must be setup separately.
> 
> This seperate initialization is error prone and awkward to use. The
> seperate initialization is also problematic for a clean Rust abstraction.
> 
> A combined setup function like timer_setup() is less error prone and
> simpler to use.
> 
> This first part of the conversion provides:
> 
>   - a set of hrtimer_setup*() variants, which take the function pointer as
>     argument.
> 
>   - hrtimer_update_function() which allows to change the callback function
>     after initialization with the proper safety checks in place.
> 
>   - conversion of the hrtimer_init*_on_stack() variants
> 
>   - some minor cleanups
> 
> The remaining users will be converted in follow up series.
> 
> Most conversions were done with Coccinelle. See sematic patch below.
> 
> Changes versus v1:
>   - Open code kvm_xen_init_vcpu() (Sean)
>   - Drop the can/bcm patch (Oliver)
>   - Folded the removal of hrtimer_init_sleeper() (tglx)
>   - Update change logs and cover letter
> 
> The series applies on top of:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
> 
> and is also available from git:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git hrtimer-setup-part1-v2
> 
> Best regards,
> 
> Nam