linux-kernel - Re: [PATCH net] wifi: brcmfmac: release 'root' node in all execution paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc0657cd-083c-4abe-8f27-0b5a49cdd35a@gmail.com>
Date: Thu, 31 Oct 2024 15:46:21 +0100
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Kalle Valo <kvalo@...nel.org>
Cc: Arend van Spriel <arend.vanspriel@...adcom.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Hector Martin <marcan@...can.st>, Alvin Šipraga
 <alsi@...g-olufsen.dk>, linux-wireless@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] wifi: brcmfmac: release 'root' node in all execution
 paths

On 31/10/2024 15:18, Kalle Valo wrote:
> Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:
> 
>> The fixed patch introduced an additional condition to enter the scope
>> where the 'root' device_node is released (!settings->board_type,
>> currently 'err'), which avoid decrementing the refcount with a call to
>> of_node_put() if that second condition is not satisfied.
>>
>> Move the call to of_node_put() to the point where 'root' is no longer
>> required to avoid leaking the resource if err is not zero.
>>
>> Cc: stable@...r.kernel.org
>> Fixes: 7682de8b3351 ("wifi: brcmfmac: of: Fetch Apple properties")
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> Wireless patches go to wireless trees, not net. But no need to resend because
> of this. And I think wireless-next is approriate for this fix.
> 


Sorry, the second link from your signature explains very well what I
should have done. I will keep that in mind for the next patch(es) to
wireless.

Thank you and best regards,
Javier Carrasco