[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241101153240.26c6c5ea@jic23-huawei>
Date: Fri, 1 Nov 2024 15:32:40 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Julien Stephan <jstephan@...libre.com>
Cc: Mudit Sharma <muditsharma.info@...il.com>, Lars-Peter Clausen
<lars@...afoo.de>, Anshul Dalal <anshulusr@...il.com>, Javier Carrasco
<javier.carrasco.cruz@...il.com>, Jean-Baptiste Maneyrol
<jean-baptiste.maneyrol@....com>, Michael Hennerich
<Michael.Hennerich@...log.com>, Cosmin Tanislav
<cosmin.tanislav@...log.com>, Ramona Gradinariu
<ramona.gradinariu@...log.com>, Antoniu Miclaus
<antoniu.miclaus@...log.com>, Dan Robertson <dan@...obertson.com>, Marcelo
Schmitt <marcelo.schmitt@...log.com>, Matteo Martelli
<matteomartelli3@...il.com>, Anand Ashok Dumbre
<anand.ashok.dumbre@...inx.com>, Michal Simek <michal.simek@....com>,
Mariel Tinaco <Mariel.Tinaco@...log.com>, Jagath Jog J
<jagathjog1996@...il.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Subhajit
Ghosh <subhajit.ghosh@...aklogic.com>, Kevin Tsai <ktsai@...ellamicro.com>,
Linus Walleij <linus.walleij@...aro.org>, Benson Leung
<bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v2 01/15] iio: light: ltr390: simplify code in
write_event_config callback
On Thu, 31 Oct 2024 16:26:56 +0100
Julien Stephan <jstephan@...libre.com> wrote:
> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@...libre.com>
Given these are good cleanup even without the final patches I'm going to
pick them up as I go. Maybe I'll end up taking the lot though!
Applied this one.
Thanks
Jonathan
> ---
> drivers/iio/light/ltr390.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
> index 8e0a3fc3d923a6f65d2a629c87e7bfd35d82a507..3bdffb6360bcbaab4df1a2d39c8ea3813b5d6bd3 100644
> --- a/drivers/iio/light/ltr390.c
> +++ b/drivers/iio/light/ltr390.c
> @@ -558,10 +558,7 @@ static int ltr390_write_event_config(struct iio_dev *indio_dev,
> struct ltr390_data *data = iio_priv(indio_dev);
> int ret;
>
> - if (state != 1 && state != 0)
> - return -EINVAL;
> -
> - if (state == 0)
> + if (!state)
> return regmap_clear_bits(data->regmap, LTR390_INT_CFG, LTR390_LS_INT_EN);
>
> guard(mutex)(&data->lock);
>
Powered by blists - more mailing lists