[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241101-left-handshake-7efc5a202311@spud>
Date: Fri, 1 Nov 2024 17:14:50 +0000
From: Conor Dooley <conor@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Suraj Gupta <suraj.gupta2@....com>, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, radhey.shyam.pandey@....com,
andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
git@....com, harini.katakam@....com
Subject: Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Correct
phy-mode property value
On Thu, Oct 31, 2024 at 06:53:12PM -0700, Jakub Kicinski wrote:
> On Mon, 28 Oct 2024 14:42:14 +0530 Suraj Gupta wrote:
> > Correct phy-mode property value to 1000base-x.
> >
> > Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> > Signed-off-by: Suraj Gupta <suraj.gupta2@....com>
> > ---
> > Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > index e95c21628281..fb02e579463c 100644
> > --- a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml
> > @@ -61,7 +61,7 @@ properties:
> > - gmii
> > - rgmii
> > - sgmii
> > - - 1000BaseX
> > + - 1000base-x
> >
> > xlnx,phy-type:
> > description:
>
> Can we get an ack from DT folks?
I dunno, the commit message gives no detail at all about the impact of
changing this, so I don't want to ack it. I *assume* that this is parsed
by common code and 1000BaseX is not understood by that common code,
but...
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists