linux-kernel - Re: [PATCH] perf trace: avoid garbage when not printing an trace event's arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEmfU+sBLFzfRLGjWaaT66=DZjiK+HDcZikLuLvzsMWZiDFPpg@mail.gmail.com>
Date: Fri, 1 Nov 2024 10:26:46 -0700
From: Benjamin Peterson <benjamin@...flow.com>
To: Howard Chu <howardchu95@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	"Liang, Kan" <kan.liang@...ux.intel.com>, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@...r.kernel.org>, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf trace: avoid garbage when not printing an trace
 event's arguments

On Thu, Oct 31, 2024 at 7:03 PM Howard Chu <howardchu95@...il.com> wrote:
>
> Hello Benjamin,
>
> It does not build on my system due to this warning:
>
> builtin-trace.c: In function ‘trace__fprintf_tp_fields’:
> builtin-trace.c:3090:35: error: field precision specifier ‘.*’ expects
> argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long
> unsigned int’} [-Werror=format=]
>  3090 |         fprintf(trace->output, "%.*s", printed, bf);
>       |                                 ~~^~   ~~~~~~~
>       |                                   |    |
>       |                                   int  size_t {aka long unsigned int}

Thanks; that's what I getting for building with clang rather than gcc.
v2 incoming...