| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241101015101.98111-1-qiang4.zhang@linux.intel.com>
Date: Fri, 1 Nov 2024 09:50:58 +0800
From: qiang4.zhang@...ux.intel.com
To: "Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
Eugenio Pérez <eperezma@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
Jens Axboe <axboe@...nel.dk>,
Olivia Mackall <olivia@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Amit Shah <amit@...nel.org>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Gonglei <arei.gonglei@...wei.com>,
"David S. Miller" <davem@...emloft.net>,
Viresh Kumar <viresh.kumar@...aro.org>,
"Chen, Jian Jun" <jian.jun.chen@...el.com>,
Andi Shyti <andi.shyti@...nel.org>,
Andrew Lunn <andrew+netdev@...n.ch>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
David Hildenbrand <david@...hat.com>,
Gerd Hoffmann <kraxel@...hat.com>,
Anton Yakovlev <anton.yakovlev@...nsynergy.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>
Cc: Qiang Zhang <qiang4.zhang@...el.com>,
virtualization@...ts.linux.dev,
linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-crypto@...r.kernel.org,
linux-i2c@...r.kernel.org,
netdev@...r.kernel.org,
linux-scsi@...r.kernel.org,
linux-sound@...r.kernel.org
Subject: [PATCH v2] virtio: only reset device and restore status if needed in device resume
From: Qiang Zhang <qiang4.zhang@...el.com>
Virtio core unconditionally reset and restore status for all virtio
devices before calling restore method. This breaks some virtio drivers
which don't need to do anything in suspend and resume because they
just want to keep device state retained.
Virtio GPIO is a typical example. GPIO states should be kept unchanged
after suspend and resume (e.g. output pins keep driving the output) and
Virtio GPIO driver does nothing in freeze and restore methods. But the
reset operation in virtio_device_restore breaks this.
Since some devices need reset in suspend and resume while some needn't,
create a new helper function for the original reset and status restore
logic so that virtio drivers can invoke it in their restore method
if necessary.
Signed-off-by: Qiang Zhang <qiang4.zhang@...el.com>
---
v1 -> v2:
- Fix compilation error when CONFIG_PM_SLEEP is disabled. Move
virtio_device_reset_and_restore_status out of CONFIG_PM_SLEEP scope.
drivers/block/virtio_blk.c | 4 ++
drivers/char/hw_random/virtio-rng.c | 4 ++
drivers/char/virtio_console.c | 4 ++
drivers/crypto/virtio/virtio_crypto_core.c | 4 ++
drivers/i2c/busses/i2c-virtio.c | 6 ++
drivers/net/virtio_net.c | 4 ++
drivers/scsi/virtio_scsi.c | 4 ++
drivers/virtio/virtio.c | 83 ++++++++++++----------
drivers/virtio/virtio_balloon.c | 4 ++
drivers/virtio/virtio_input.c | 4 ++
drivers/virtio/virtio_mem.c | 4 ++
include/linux/virtio.h | 1 +
sound/virtio/virtio_card.c | 4 ++
13 files changed, 94 insertions(+), 36 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 194417abc105..bba7148bd219 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -1612,6 +1612,10 @@ static int virtblk_restore(struct virtio_device *vdev)
struct virtio_blk *vblk = vdev->priv;
int ret;
+ ret = virtio_device_reset_and_restore_status(vdev);
+ if (ret)
+ return ret;
+
ret = init_vq(vdev->priv);
if (ret)
return ret;
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index dd998f4fe4f2..954280514f5a 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c
@@ -218,6 +218,10 @@ static int virtrng_restore(struct virtio_device *vdev)
{
int err;
+ err = virtio_device_reset_and_restore_status(vdev);
+ if (err)
+ return err;
+
err = probe_common(vdev);
if (!err) {
struct virtrng_info *vi = vdev->priv;
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index c62b208b42f1..c431e4d5cd29 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -2132,6 +2132,10 @@ static int virtcons_restore(struct virtio_device *vdev)
portdev = vdev->priv;
+ ret = virtio_device_reset_and_restore_status(vdev);
+ if (ret)
+ return ret;
+
ret = init_vqs(portdev);
if (ret)
return ret;
diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c
index d0278eb568b9..b3363dd80448 100644
--- a/drivers/crypto/virtio/virtio_crypto_core.c
+++ b/drivers/crypto/virtio/virtio_crypto_core.c
@@ -536,6 +536,10 @@ static int virtcrypto_restore(struct virtio_device *vdev)
struct virtio_crypto *vcrypto = vdev->priv;
int err;
+ err = virtio_device_reset_and_restore_status(vdev);
+ if (err)
+ return err;
+
err = virtcrypto_init_vqs(vcrypto);
if (err)
return err;
diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c
index 2a351f961b89..ce6493d6fe8e 100644
--- a/drivers/i2c/busses/i2c-virtio.c
+++ b/drivers/i2c/busses/i2c-virtio.c
@@ -251,6 +251,12 @@ static int virtio_i2c_freeze(struct virtio_device *vdev)
static int virtio_i2c_restore(struct virtio_device *vdev)
{
+ int ret;
+
+ ret = virtio_device_reset_and_restore_status(vdev);
+ if (ret)
+ return ret;
+
return virtio_i2c_setup_vqs(vdev->priv);
}
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 792e9eadbfc3..5be2a5f68f68 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -6693,6 +6693,10 @@ static __maybe_unused int virtnet_restore(struct virtio_device *vdev)
struct virtnet_info *vi = vdev->priv;
int err;
+ err = virtio_device_reset_and_restore_status(vdev);
+ if (err)
+ return err;
+
err = virtnet_restore_up(vdev);
if (err)
return err;
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 8471f38b730e..3aeddf6331d3 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -1016,6 +1016,10 @@ static int virtscsi_restore(struct virtio_device *vdev)
struct virtio_scsi *vscsi = shost_priv(sh);
int err;
+ err = virtio_device_reset_and_restore_status(vdev);
+ if (err)
+ return err;
+
err = virtscsi_init(vdev, vscsi);
if (err)
return err;
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index b9095751e43b..55f80a61fb85 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -527,6 +527,41 @@ void unregister_virtio_device(struct virtio_device *dev)
}
EXPORT_SYMBOL_GPL(unregister_virtio_device);
+int virtio_device_reset_and_restore_status(struct virtio_device *dev)
+{
+ struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
+ int ret;
+
+ /* We always start by resetting the device, in case a previous
+ * driver messed it up. */
+ virtio_reset_device(dev);
+
+ /* Acknowledge that we've seen the device. */
+ virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
+
+ /* Maybe driver failed before freeze.
+ * Restore the failed status, for debugging. */
+ if (dev->failed)
+ virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED);
+
+ if (!drv)
+ return 0;
+
+ /* We have a driver! */
+ virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
+
+ ret = dev->config->finalize_features(dev);
+ if (ret)
+ return ret;
+
+ ret = virtio_features_ok(dev);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(virtio_device_reset_and_restore_status);
+
#ifdef CONFIG_PM_SLEEP
int virtio_device_freeze(struct virtio_device *dev)
{
@@ -554,44 +589,20 @@ int virtio_device_restore(struct virtio_device *dev)
struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
int ret;
- /* We always start by resetting the device, in case a previous
- * driver messed it up. */
- virtio_reset_device(dev);
-
- /* Acknowledge that we've seen the device. */
- virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
-
- /* Maybe driver failed before freeze.
- * Restore the failed status, for debugging. */
- if (dev->failed)
- virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED);
-
- if (!drv)
- return 0;
-
- /* We have a driver! */
- virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
-
- ret = dev->config->finalize_features(dev);
- if (ret)
- goto err;
-
- ret = virtio_features_ok(dev);
- if (ret)
- goto err;
-
- if (drv->restore) {
- ret = drv->restore(dev);
- if (ret)
- goto err;
+ if (drv) {
+ if (drv->restore) {
+ ret = drv->restore(dev);
+ if (ret)
+ goto err;
+ }
+
+ /* If restore didn't do it, mark device DRIVER_OK ourselves. */
+ if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))
+ virtio_device_ready(dev);
+
+ virtio_config_core_enable(dev);
}
- /* If restore didn't do it, mark device DRIVER_OK ourselves. */
- if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))
- virtio_device_ready(dev);
-
- virtio_config_core_enable(dev);
-
return 0;
err:
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index b36d2803674e..ba92b3e56391 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -1163,6 +1163,10 @@ static int virtballoon_restore(struct virtio_device *vdev)
struct virtio_balloon *vb = vdev->priv;
int ret;
+ ret = virtio_device_reset_and_restore_status(vdev);
+ if (ret)
+ return ret;
+
ret = init_vqs(vdev->priv);
if (ret)
return ret;
diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
index a5d63269f20b..81c2ffd0e76e 100644
--- a/drivers/virtio/virtio_input.c
+++ b/drivers/virtio/virtio_input.c
@@ -374,6 +374,10 @@ static int virtinput_restore(struct virtio_device *vdev)
struct virtio_input *vi = vdev->priv;
int err;
+ err = virtio_device_reset_and_restore_status(vdev);
+ if (err)
+ return err;
+
err = virtinput_init_vqs(vi);
if (err)
return err;
diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index b0b871441578..47c23aa43c20 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -3018,6 +3018,10 @@ static int virtio_mem_restore(struct virtio_device *vdev)
struct virtio_mem *vm = vdev->priv;
int ret;
+ ret = virtio_device_reset_and_restore_status(vdev);
+ if (ret)
+ return ret;
+
ret = virtio_mem_init_vq(vm);
if (ret)
return ret;
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 306137a15d07..bce26597b8fc 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -178,6 +178,7 @@ int virtio_device_freeze(struct virtio_device *dev);
int virtio_device_restore(struct virtio_device *dev);
#endif
void virtio_reset_device(struct virtio_device *dev);
+int virtio_device_reset_and_restore_status(struct virtio_device *dev);
size_t virtio_max_dma_size(const struct virtio_device *vdev);
diff --git a/sound/virtio/virtio_card.c b/sound/virtio/virtio_card.c
index 965209e1d872..3c7a6d76c46c 100644
--- a/sound/virtio/virtio_card.c
+++ b/sound/virtio/virtio_card.c
@@ -412,6 +412,10 @@ static int virtsnd_restore(struct virtio_device *vdev)
struct virtio_snd *snd = vdev->priv;
int rc;
+ rc = virtio_device_reset_and_restore_status(vdev);
+ if (rc)
+ return rc;
+
rc = virtsnd_find_vqs(snd);
if (rc)
return rc;
--
2.45.2
Powered by blists - more mailing lists