linux-kernel - Re: [PATCH net] bnxt_en: ethtool: Fix ip[6] ntuple rule verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLim3y5-XMBCpCMA-XnLe6yho6fY0Hbcu_1jbf5JKrhCH9w@mail.gmail.com>
Date: Fri, 1 Nov 2024 12:20:44 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Daniel Xu <dxu@...uu.xyz>
Cc: davem@...emloft.net, edumazet@...gle.com, andrew+netdev@...n.ch, 
	kuba@...nel.org, vikas.gupta@...adcom.com, andrew.gospodarek@...adcom.com, 
	pabeni@...hat.com, pavan.chebbi@...adcom.com, martin.lau@...ux.dev, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net] bnxt_en: ethtool: Fix ip[6] ntuple rule verification

On Thu, Oct 31, 2024 at 9:59 PM Daniel Xu <dxu@...uu.xyz> wrote:
>
> Previously, trying to insert an ip or ip6 only rule would get rejected
> with -EOPNOTSUPP. For example, the following would fail:
>
>     ethtool -N eth0 flow-type ip6 dst-ip $IP6 context 1
>
> The reason was that all the l4proto validation was being run despite the
> l4proto mask being set to 0x0.  Fix by only running l4proto validation
> when mask is set.
>
> Fixes: 9ba0e56199e3 ("bnxt_en: Enhance ethtool ntuple support for ip flows besides TCP/UDP")
> Signed-off-by: Daniel Xu <dxu@...uu.xyz>

Thanks for the patch.  I think the original author Vikas intended the
user to do this for ip only filters:

ethtool -N eth0 flow-type ip6 dst-ip $IP6 l4_proto 0xff context 1

But your patch makes sense and simplifies the usage for the user.  I
just need to check that FW can accept 0 for the ip_protocol field to
mean wildcard when it receives the FW message to create the filter.

I will reply when I get the answer from the FW team.  If FW requires
0xff, then we just need to make a small change to your patch.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)