linux-kernel - Re: [PATCH] KVM: x86: Ensure vcpu->mode is loaded from memory in kvm_vcpu_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyUrbykshu2YcrfR@google.com>
Date: Fri, 1 Nov 2024 12:26:39 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Ensure vcpu->mode is loaded from memory in kvm_vcpu_exit_request()

On Thu, Oct 31, 2024, Sean Christopherson wrote:
> On Wed, 28 Aug 2024 16:20:13 -0700, Sean Christopherson wrote:
> > Wrap kvm_vcpu_exit_request()'s load of vcpu->mode with READ_ONCE() to
> > ensure the variable is re-loaded from memory, as there is no guarantee the
> > caller provides the necessary annotations to ensure KVM sees a fresh value,
> > e.g. the VM-Exit fastpath could theoretically reuse the pre-VM-Enter value.
> 
> Applied to kvm-x86 misc, thanks!
> 
> [1/1] KVM: x86: Ensure vcpu->mode is loaded from memory in kvm_vcpu_exit_request()
>       https://github.com/kvm-x86/linux/commit/ba50bb4a9fb5

FYI, I rebased misc to v6.12-rc5, as patches in another series had already been
taken through the tip tree.  New hash:

[1/1] KVM: x86: Ensure vcpu->mode is loaded from memory in kvm_vcpu_exit_request()
      https://github.com/kvm-x86/linux/commit/3ffe874ea3eb