linux-kernel - Re: [PATCH V3] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7d85678-c242-6a92-55d3-bb593e508f28@igalia.com>
Date: Fri, 1 Nov 2024 16:38:32 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: "kvalo@...nel.org" <kvalo@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "kernel@...ccoli.net" <kernel@...ccoli.net>,
 "kernel-dev@...lia.com" <kernel-dev@...lia.com>,
 "rtl8821cerfe2@...il.com" <rtl8821cerfe2@...il.com>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>,
 "syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com"
 <syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com>,
 "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH V3] wifi: rtlwifi: Drastically reduce the attempts to read
 efuse in case of failures

>> [...]
>>         struct rtl_priv *rtlpriv = rtl_priv(hw);
>> +       u16 retry, max_attempts;
>>         u32 value32;
>>         u8 readbyte;
>> -       u16 retry;
>> +
>> +       /*
>> +        * In case of USB devices, transfer speeds are limited, hence
>> +        * efuse I/O reads could be (way) slower. So, decrease (a lot)
>> +        * the read attempts in case of failures.
>> +        */
>> +       if (rtlpriv->rtlhal.interface == INTF_PCI)
>> +               max_attempts = 10000;
>> +       else
>> +               max_attempts = 10;
> 
> As your comment, setting max_atttempts to 10 under condition of INTF_USB would
> be more reasonable, like
> 
>     u16 max_attempts = 10000;
> 
>     if (rtlpriv->rtlhal.interface == INTF_USB)
>         max_attempts = 10;
> 

OK, thanks.

V4 just sent:
https://lore.kernel.org/r/20241101193412.1390391-1-gpiccoli@igalia.com