linux-kernel - Re: [PATCH 3/9] Update messaging and usb_device refs in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab4f8854-8d97-4c9c-bff1-86a73b4f7cab@stanley.mountain>
Date: Fri, 1 Nov 2024 22:48:16 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	arnd@...db.de
Subject: Re: [PATCH 3/9] Update messaging and usb_device refs in ni_usb

On Fri, Nov 01, 2024 at 06:46:59PM +0100, Dave Penkler wrote:
>       Replace GPIB_DPRINTK with dev_dbg
>       Replace pr_xxx with dev_xxx wherever possible
>       Use previously initialized usb_device pointer
>       for usb_get_dev() and usb_put_dev().
> 
> Signed-off-by: Dave Penkler <dpenkler@...il.com>
> ---
>  drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 377 ++++++++++++----------
>  1 file changed, 205 insertions(+), 172 deletions(-)
> 
> diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
> index 9ff56b063681..50ec934fe8be 100644
> --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
> +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
> @@ -132,13 +132,14 @@ static int ni_usb_nonblocking_send_bulk_msg(struct ni_usb_priv *ni_priv, void *d
>  	if (timeout_msecs)
>  		mod_timer(&ni_priv->bulk_timer, jiffies + msecs_to_jiffies(timeout_msecs));
>  
> -	//pr_err("%s: submitting urb\n", __func__);
> +	//dev_err(&usb_dev->dev, "%s: submitting urb\n", __func__);

Just delete commented out code.

regards,
dan carpenter