linux-kernel - Re: [GIT PULL] nolibc changes for v6.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241101220128.GA15188@1wt.eu>
Date: Fri, 1 Nov 2024 23:01:28 +0100
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: "Paul E. McKenney" <paulmck@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] nolibc changes for v6.13

On Fri, Nov 01, 2024 at 09:40:34PM +0000, Thomas Weißschuh wrote:
> > Maybe we could just enclose the test with:
> > 
> > #if !defined(__GLIBC__) || __GLIBC__ > 2 || __GLIBC_MINOR__ >= 40
> >  ...
> > #endif
> 
> This will mess up the test case numbers.
> The test is actually only running on nolibc anyways, so we could also
> stub out strlcat() with a dummy inline function.

OK.

> > > For better architecture coverage I would recommend ./run-tests.sh over
> > > "make run/user". Speaking about this I remember the discussion from the
> > > 6.12 PR where Willy proposed an improved run-tests.sh error message.
> > > It seems he didn't push it as a commit, so let's add keep it in mind for
> > > next cycle.
> > 
> > Oups, I vaguely remember proposing a trivial patch in an e-mail a while
> > ago but I don't even remember what it was about. My mind is totally taken
> > by the upcoming haproxy release these days :-/
> 
> It's at https://lore.kernel.org/lkml/ZtlQbpgpn9OQOPyI@1wt.eu/
> No worries, I'll pick it up after 6.13-rc1.

Ah, I found it, it reminded me something, because usually I forget about
patches once I commit them! I had pushed it to the next branch by then:

  commit 6fc1d365c7394790cf7073a4acfcbf7fe4e8eff9 (HEAD -> 20240908-nolibc-next, korg-nolibc-git/next)
  Author: Willy Tarreau <w@....eu>
  Date:   Sun Sep 8 12:00:12 2024 +0200

    selftests/nolibc: run-tests.sh: detect missing toolchain
    
    The script tries to resolve the path to the current toolchain using
    realpath, which fails in case it's not installed, and since it's run
    under -e, it doesn't have the opportunity to display a help message.
    Let's detect the absence of the required toolchain before running that
    command and provide a friendlier message when this happens.
    
    Link: https://lore.kernel.org/all/ZtlQbpgpn9OQOPyI@1wt.eu/
    Signed-off-by: Willy Tarreau <w@....eu>

Seems like we messed up with a forced push to next at some point :-)

I rebased it on the current next and pushed it again:

    648da1b274cf85fff5fe60914ae6a402013f456c

Cheers,
Willy