linux-kernel - Re: [PATCH v6 3/7] Adjust symbol ordering in text output section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARZ3Hw-OuMe39eOHR=H1BSpyaGQf4xUFW9tuOWFnEzXqw@mail.gmail.com>
Date: Sat, 2 Nov 2024 07:03:54 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Rong Xu <xur@...gle.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Arnd Bergmann <arnd@...db.de>, Bill Wendling <morbo@...gle.com>, Borislav Petkov <bp@...en8.de>, 
	Breno Leitao <leitao@...ian.org>, Brian Gerst <brgerst@...il.com>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, David Li <davidxl@...gle.com>, 
	Han Shen <shenhan@...gle.com>, Heiko Carstens <hca@...ux.ibm.com>, "H. Peter Anvin" <hpa@...or.com>, 
	Ingo Molnar <mingo@...hat.com>, Jann Horn <jannh@...gle.com>, Jonathan Corbet <corbet@....net>, 
	Josh Poimboeuf <jpoimboe@...nel.org>, Juergen Gross <jgross@...e.com>, 
	Justin Stitt <justinstitt@...gle.com>, Kees Cook <kees@...nel.org>, 
	"Mike Rapoport (IBM)" <rppt@...nel.org>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Nicolas Schier <nicolas@...sle.eu>, 
	"Paul E. McKenney" <paulmck@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Sami Tolvanen <samitolvanen@...gle.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Wei Yang <richard.weiyang@...il.com>, workflows@...r.kernel.org, 
	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Maksim Panchenko <max4bolt@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>, 
	Yonghong Song <yonghong.song@...ux.dev>, Yabin Cui <yabinc@...gle.com>, 
	Krzysztof Pszeniczny <kpszeniczny@...gle.com>, Sriraman Tallam <tmsriram@...gle.com>, 
	Stephane Eranian <eranian@...gle.com>, x86@...nel.org, linux-arch@...r.kernel.org, 
	sparclinux@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev
Subject: Re: [PATCH v6 3/7] Adjust symbol ordering in text output section

On Sat, Nov 2, 2024 at 3:37 AM Rong Xu <xur@...gle.com> wrote:
>
> Current order is:
> .text.hot, .text, .text_unlikely, .text.unknown, .text.asan
>
> The patch reorders them to:
> .text.asan, .text.unknown, .text_unlikely, .text.hot, .text
>
> The majority of the code resides in three sections: .text.hot, .text, and
>  .text.unlikely, with .text.unknown containing a negligible amount.
> .text.asan is only generated in ASAN builds.
>
> Our primary goal is to group code segments based on their execution
> frequency (hotness).
>
> First, we want to place .text.hot adjacent to .text. Since we cannot put
> .text.hot after .text (Due to constraints with -ffunction-sections,
> placing .text.hot after .text is problematic), we need to put
> .text.hot before .text.
>
> Then it comes to .text.unlikely, we cannot put it after .text
> (same -ffunction-sections issue) . Therefore, we'll position .text.unlikely
> before .text.hot.
>
> .text.unknown and .tex.asan follow the same logic.
>
> This revised ordering effectively reverses the original arrangement (for
> .text.unlikely, .text.unknown, and .tex.asan), maintaining a similar level of
> affinity between sections.
>
> I hope this explains the reason for the new ordering.


Make sense.

Please describe the above in the commit description.

Then, it will be clearer why you not only moved up fixed patterns
but also reversed the order.







-- 
Best Regards
Masahiro Yamada