linux-kernel - Re: [PATCH v4 2/3] watchdog: aspeed: Change aspeed_wdt_config struct name to aspeed_wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c91f8b3c-ae3f-4d35-8b7f-2fb2b7cebebd@roeck-us.net>
Date: Fri, 1 Nov 2024 15:19:37 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>, patrick@...cx.xyz,
 joel@....id.au, andrew@...econstruct.com.au, wim@...ux-watchdog.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Cc: Peter.Yin@...ntatw.com, Patrick_NC_Lin@...ynn.com, Bonnie_Lo@...ynn.com,
 DELPHINE_CHIU@...ynn.com, bmc-sw@...eedtech.com, chnguyen@...erecomputing.com
Subject: Re: [PATCH v4 2/3] watchdog: aspeed: Change aspeed_wdt_config struct
 name to aspeed_wdt_data

On 11/1/24 05:12, Chin-Ting Kuo wrote:
> aspeed_wdt_config struct is used to store some HW configuration
> information. Changing its naming to a more generic one,
> aspeed_wdt_data, in order to contain more platform specific
> inforamtion or SW callback functions.
> 
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>

I fail to see the point of this patch. It is just unnecessary churn.
Just like drivers should not be renamed because of an extended scope
or because someone doesn't like the old name, renaming variables should
be avoided as well. Such renames just make future bug fixes (which may
need to be backported) more difficult.

Guenter