linux-kernel - RE: [PATCH V3] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae95544aabe74d1da801fed6cc73896e@realtek.com>
Date: Fri, 1 Nov 2024 02:26:56 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC: "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "kernel@...ccoli.net" <kernel@...ccoli.net>,
        "kernel-dev@...lia.com" <kernel-dev@...lia.com>,
        "rtl8821cerfe2@...il.com"
	<rtl8821cerfe2@...il.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com"
	<syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com>
Subject: RE: [PATCH V3] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures

> 
> [0] Commit 15fffc6a5624 ("driver core: Fix uevent_show() vs driver detach race").
> 
> [1] A note about that: this syzkaller report presents multiple reproducers
> that differs by the type of emulated USB device. For this specific case,
> check the entry from 2024/08/08 06:23 in the list of crashes; the C repro
> is available at https://syzkaller.appspot.com/text?tag=ReproC&x=1521fc83980000.

Have you run checkpatch before submission? Above two information can be in
formal form as suggestions of checkpatch. 

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#55:
in case of failures, restricted to USB devices (given that they're inherently

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#72:
Reported-by: syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com
Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>

WARNING: The commit message has 'syzkaller', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 3 warnings, 0 checks, 28 lines checked

> 
> Cc: stable@...r.kernel.org # v6.1+
> Reported-by: syzbot+edd9fe0d3a65b14588d5@...kaller.appspotmail.com
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>