linux-kernel - Re: [PATCH 2/2] kasan: change kasan_atomics kunit test as KUNIT_CASE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZd9V8okaozn-LBA3w=TsuVbTR=4Hey+w1+_CRDVQV_XEA@mail.gmail.com>
Date: Sat, 2 Nov 2024 00:38:36 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Sabyrzhan Tasbolatov <snovitoll@...il.com>
Cc: ryabinin.a.a@...il.com, elver@...gle.com, arnd@...nel.org, 
	glider@...gle.com, dvyukov@...gle.com, vincenzo.frascino@....com, 
	akpm@...ux-foundation.org, kasan-dev@...glegroups.com, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] kasan: change kasan_atomics kunit test as KUNIT_CASE_SLOW

On Fri, Nov 1, 2024 at 7:40 PM Sabyrzhan Tasbolatov <snovitoll@...il.com> wrote:
>
> During running KASAN Kunit tests with CONFIG_KASAN enabled, the
> following "warning" is reported by kunit framework:
>
>         # kasan_atomics: Test should be marked slow (runtime: 2.604703115s)
>
> It took 2.6 seconds on my PC (Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz),
> apparently, due to multiple atomic checks in kasan_atomics_helper().
>
> Let's mark it with KUNIT_CASE_SLOW which reports now as:
>
>         # kasan_atomics.speed: slow
>
> Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@...il.com>
> ---
>  mm/kasan/kasan_test_c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c
> index 3e495c09342e..3946fc89a979 100644
> --- a/mm/kasan/kasan_test_c.c
> +++ b/mm/kasan/kasan_test_c.c
> @@ -2020,7 +2020,7 @@ static struct kunit_case kasan_kunit_test_cases[] = {
>         KUNIT_CASE(kasan_strings),
>         KUNIT_CASE(kasan_bitops_generic),
>         KUNIT_CASE(kasan_bitops_tags),
> -       KUNIT_CASE(kasan_atomics),
> +       KUNIT_CASE_SLOW(kasan_atomics),
>         KUNIT_CASE(vmalloc_helpers_tags),
>         KUNIT_CASE(vmalloc_oob),
>         KUNIT_CASE(vmap_tags),
> --
> 2.34.1
>

Reviewed-by: Andrey Konovalov <andreyknvl@...il.com>