linux-kernel - Re: [net-next PATCH v2 4/6] octeontx2-pf: CN20K mbox REQ/ACK implementation for NIC PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BY3PR18MB47073B021828F4F4C8E38BC7A0562@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Fri, 1 Nov 2024 05:50:06 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Linu Cherian <lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@...vell.com>,
        "kalesh-anakkur.purayil@...adcom.com"
	<kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [net-next PATCH v2 4/6] octeontx2-pf: CN20K mbox REQ/ACK
 implementation for NIC PF

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, October 30, 2024 4:37 AM
> To: Sai Krishna Gajula <saikrishnag@...vell.com>
> Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@...vell.com>; Geethasowjanya Akula
> <gakula@...vell.com>; Linu Cherian <lcherian@...vell.com>; Jerin Jacob
> <jerinj@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>; Subbaraya
> Sundeep Bhatta <sbhatta@...vell.com>; kalesh-
> anakkur.purayil@...adcom.com
> Subject: Re: [net-next PATCH v2 4/6] octeontx2-pf: CN20K mbox
> REQ/ACK implementation for NIC PF
> 
> On Wed, 23 Oct 2024 00: 24: 08 +0530 Sai Krishna wrote: > +/** > + * CN20k
> RVU PF MBOX Interrupt Vector Enumeration > + * > + * Vectors 0 - 3 are
> compatible with pre cn20k and hence > + * existing macros are being reused.
> > +
> On Wed, 23 Oct 2024 00:24:08 +0530 Sai Krishna wrote:
> > +/**
> > + * CN20k RVU PF MBOX Interrupt Vector Enumeration
> > + *
> > + * Vectors 0 - 3 are compatible with pre cn20k and hence
> > + * existing macros are being reused.
> > + */
> 
> Please don't use /** unless the comment is in kernel-doc format.
> It causes warnings for documentation extractors:

Ack,  Will submit V3 patch with correcting the error.

> 
>  drivers/net/ethernet/marvell/octeontx2/af/cn20k/struct.h:12: warning: This
> comment starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>   * CN20k RVU PF MBOX Interrupt Vector Enumeration
>  drivers/net/ethernet/marvell/octeontx2/af/cn20k/struct.h:12: warning:
> missing initial short description on line:
>   * CN20k RVU PF MBOX Interrupt Vector Enumeration
> --
> pw-bot: cr

Thanks,
Sai