linux-kernel - Re: [PATCH] kdb: Fix incorrect naming of history arrow keys in code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241101062115.GA32320@lichtman.org>
Date: Fri, 1 Nov 2024 06:21:15 +0000
From: Nir Lichtman <nir@...htman.org>
To: Doug Anderson <dianders@...omium.org>
Cc: jason.wessel@...driver.com, daniel.thompson@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kdb: Fix incorrect naming of history arrow keys in code

On Fri, Nov 01, 2024 at 12:26:12AM +0000, Nir Lichtman wrote:
> 
> Evidence in the code for usage of arrow keys in the case of keyboard can
> be seen by examining kdb_read in kernel/debug/kdb/kdb_io.c, in the /* Down */
> and /* Up */ cases the values 14 and 16 can be seen.
> 

Correction: The evidence can be seen in the kdb_keyboard.c file
in the function kdb_get_kbd_char which gets the scan codes from the keyboard.
The conversion between the up and down arrow scan codes to the 16 and 14 values
is at lines 138 until 141.

I am thinking maybe a good solution for this confusing passing of magics
is to export the magics to macro definitions,
or maybe to make the keyboard flow also actually use CTRL chords?

Thanks,
Nir