linux-kernel - Re: [PATCH v1 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zdbnxzv2q4lfer5hvdtcuzr3jfligi7y3qs2o5w2orrw5rcpkg@f3wvcwdntklf>
Date: Fri, 1 Nov 2024 08:10:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Amit Sunil Dhamne <amitsd@...gle.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	gregkh@...uxfoundation.org, heikki.krogerus@...ux.intel.com, dmitry.baryshkov@...aro.org, 
	kyletso@...gle.com, rdbabiera@...gle.com, badhri@...gle.com, linux@...ck-us.net, 
	xu.yang_2@....com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: connector: Add time property for
 Sink BC12 detection completion

On Thu, Oct 31, 2024 at 04:59:52PM -0700, Amit Sunil Dhamne wrote:
> This commit adds a new time property for Battery charger (BC1.2) type
> detection completion process (based on BCv1.2 detection spec) when
> typec port connects in a potential sink role. BC1.2 detection is used
> by some Type C port controllers implementations (such as
> "maxim,max33359") to detect the type of charger port.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@...gle.com>
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 21a0c58c65cd..67700440e23b 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -283,6 +283,16 @@ properties:
>      maximum: 200
>      default: 200
>  
> +  sink-bc12-completion-time-ms:
> +    description: Represents the max time in ms that a port in sink role takes
> +      to complete Battery Charger (BC1.2) Detection. BC1.2 detection is a
> +      hardware mechanism, which in some TCPC implementations, can run in
> +      parallel once the Type-C connection state machine reaches the "potential
> +      connect as sink" state. In TCPCs where this causes delays to respond to
> +      the incoming PD messages, sink-bc12-completion-time-ms is used to delay
> +      PD negotiation till BC1.2 detection completes.
> +    default: 0

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof