linux-kernel - Re: [PATCH v2 -next] wifi: ipw2x00: fix bad alignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878qu3zasp.fsf@kernel.org>
Date: Fri, 01 Nov 2024 09:13:26 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
  "stas.yakovlev@...il.com" <stas.yakovlev@...il.com>,
  "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,  Abaci
 Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2 -next] wifi: ipw2x00: fix bad alignments

Ping-Ke Shih <pkshih@...ltek.com> writes:

> Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
>> This patch fixes incorrect code alignment.
>> 
>> ./drivers/net/wireless/intel/ipw2x00/libipw_rx.c:871:2-3: code
>> aligned with following code on line 882.
>> ./drivers/net/wireless/intel/ipw2x00/libipw_rx.c:886:2-3: code
>> aligned with following code on line 900.
>> 
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11381
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
>> ---
>> Changes in v2:
>>   -Replace the & in the if statement with &&.
>
> I feel what Kalle meant is like this:
>
> if (ether_addr_equal(hdr->addr3, ieee->bssid) &&
>     (fc & (IEEE80211_FCTL_TODS + IEEE80211_FCTL_FROMDS)) == 0)

Exactly, thanks Ping.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches