[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZySEPXOxgZj-s75F@hovoldconsulting.com>
Date: Fri, 1 Nov 2024 08:33:17 +0100
From: Johan Hovold <johan@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Johan Hovold <johan+linaro@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Abel Vesa <abel.vesa@...aro.org>,
Stephan Gerhold <stephan.gerhold@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: x1e80100-crd: describe HID supplies
On Thu, Oct 31, 2024 at 10:00:20PM +0100, Konrad Dybcio wrote:
> On 29.10.2024 8:52 AM, Johan Hovold wrote:
> > + vreg_misc_3p3: regulator-misc-3p3 {
> > + compatible = "regulator-fixed";
> > +
> > + regulator-name = "VREG_MISC_3P3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&misc_3p3_reg_en>;
>
> property-n
> property-names
>
> for consistency, please
Sure, will switch these to match the new style that this driver mostly
follows (but as we've discussed before, the traditional style that most
dt still use for pinctrl is what I used above).
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Thanks for reviewing.
Johan
Powered by blists - more mailing lists