[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <eaz4aordxjgnl7c2xhz6ek23eaapaszytcrea7a7y53b5p6aev@mtk7jsvywgcv>
Date: Fri, 1 Nov 2024 09:50:16 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Alexey Klimov <alexey.klimov@...aro.org>
Cc: linux-sound@...r.kernel.org, srinivas.kandagatla@...aro.org,
broonie@...nel.org, lgirdwood@...il.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, andersson@...nel.org, konradybcio@...nel.org, perex@...ex.cz,
tiwai@...e.com, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
krzysztof.kozlowski@...aro.org, caleb.connolly@...aro.org, linux-kernel@...r.kernel.org,
a39.skl@...il.com
Subject: Re: [PATCH v4 4/5] arm64: dts: qcom: sm4250: add LPASS LPI pin
controller
On Fri, Nov 01, 2024 at 12:59:24AM +0000, Alexey Klimov wrote:
> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin
> controller device node required for audio subsystem on Qualcomm
> QRB4210 RB2. QRB4210 is based on sm4250 which has a slightly different
> lpass pin controller comparing to sm6115.
>
> While at this, also add description of lpi_i2s2 pins (active state)
> required for audio playback via HDMI.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
> arch/arm64/boot/dts/qcom/sm4250.dtsi | 39 ++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm4250.dtsi b/arch/arm64/boot/dts/qcom/sm4250.dtsi
> index a0ed61925e12..1b9983ab122e 100644
> --- a/arch/arm64/boot/dts/qcom/sm4250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm4250.dtsi
> @@ -36,3 +36,42 @@ &cpu6 {
> &cpu7 {
> compatible = "qcom,kryo240";
> };
> +
> +&lpass_tlmm {
> + compatible = "qcom,sm4250-lpass-lpi-pinctrl";
> + gpio-ranges = <&lpass_tlmm 0 0 26>;
I think this should be <&lpass_tlmm 0 0 27>. The driver defines pins
0-26.
> +
> + lpi_i2s2_active: lpi-i2s2-active-state {
> + sck-pins {
> + pins = "gpio10";
> + function = "i2s2_clk";
> + bias-disable;
> + drive-strength = <8>;
> + output-high;
> + };
> +
> + ws-pins {
> + pins = "gpio11";
> + function = "i2s2_ws";
> + bias-disable;
> + drive-strength = <8>;
> + output-high;
> + };
> +
> + data-pins {
> + pins = "gpio12";
> + function = "i2s2_data";
> + bias-disable;
> + drive-strength = <8>;
> + output-high;
> + };
> +
> + ext-mclk1-pins {
> + pins = "gpio18";
> + function = "ext_mclk1_a";
> + bias-disable;
> + drive-strength = <16>;
> + output-high;
> + };
> + };
> +};
> --
> 2.45.2
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists