linux-kernel - Re: [PATCH 3/3] media: venus: Fix pm_runtime_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZySMyxwnedp-icoy@kekkonen.localdomain>
Date: Fri, 1 Nov 2024 08:09:47 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: mchehab@...nel.org, ming.qian@....com, eagle.zhou@....com,
	stanimir.k.varbanov@...il.com, quic_vgarodia@...cinc.com,
	bryan.odonoghue@...aro.org, hans.verkuil@...co.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 3/3] media: venus: Fix pm_runtime_set_suspended() with
 runtime pm enabled

Hi Jinjie,

On Mon, Sep 23, 2024 at 11:51:15AM +0800, Jinjie Ruan wrote:
> It is not valid to call pm_runtime_set_suspended() for devices
> with runtime PM enabled because it returns -EAGAIN if it is enabled
> already and working. So, call pm_runtime_disable() before to fix it.
> 
> Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions")

Patches with Fixes: tag(s) need to include Cc: stable nowadays. Same for
the 1st patch actually.

> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  drivers/media/platform/qcom/venus/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 165c947a6703..2d5966f5ce97 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -412,8 +412,8 @@ static int venus_probe(struct platform_device *pdev)
>  	of_platform_depopulate(dev);
>  err_runtime_disable:
>  	pm_runtime_put_noidle(dev);
> -	pm_runtime_set_suspended(dev);
>  	pm_runtime_disable(dev);
> +	pm_runtime_set_suspended(dev);
>  	hfi_destroy(core);
>  err_core_deinit:
>  	hfi_core_deinit(core, false);

-- 
Kind regards,

Sakari Ailus