[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241101101410.1449891-1-peng.fan@oss.nxp.com>
Date: Fri, 1 Nov 2024 18:14:09 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: Frank Li <Frank.Li@....com>,
Vinod Koul <vkoul@...nel.org>,
imx@...ts.linux.dev (open list:FREESCALE eDMA DRIVER),
dmaengine@...r.kernel.org (open list:FREESCALE eDMA DRIVER),
linux-kernel@...r.kernel.org (open list)
Cc: Peng Fan <peng.fan@....com>
Subject: [PATCH 1/2] dmaengine: fsl-edma: cleanup chan after dma_async_device_unregister
From: Peng Fan <peng.fan@....com>
There is kernel dump when do module test:
sysfs: cannot create duplicate filename '/devices/platform/soc@...4000000.bus/44000000.dma-controller/dma/dma0chan0'
__dma_async_device_channel_register+0x128/0x19c
dma_async_device_register+0x150/0x454
fsl_edma_probe+0x6cc/0x8a0
platform_probe+0x68/0xc8
Clean up chan after dma_async_device_unregister to address this.
Fixes: 6f93b93b2a1b ("dmaengine: fsl-edma: kill the tasklets upon exit")
Signed-off-by: Peng Fan <peng.fan@....com>
---
drivers/dma/fsl-edma-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index f9f1eda79254..01bd5cb24a49 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -668,9 +668,9 @@ static void fsl_edma_remove(struct platform_device *pdev)
struct fsl_edma_engine *fsl_edma = platform_get_drvdata(pdev);
fsl_edma_irq_exit(pdev, fsl_edma);
- fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);
of_dma_controller_free(np);
dma_async_device_unregister(&fsl_edma->dma_dev);
+ fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);
fsl_disable_clocks(fsl_edma, fsl_edma->drvdata->dmamuxs);
}
--
2.37.1
Powered by blists - more mailing lists