linux-kernel - Re: [PATCH V23 03/16] mmc: sdhci: add UHS-II module and add a kernel configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK00qKDxbdOoYx9UJEdEBb6uggof5fZV3JNar7s_cGP6ERSdzg@mail.gmail.com>
Date: Fri, 1 Nov 2024 18:39:57 +0800
From: Victor Shih <victorshihgli@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: ulf.hansson@...aro.org, adrian.hunter@...el.com, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, benchuanggli@...il.com, 
	Lucas.Lai@...esyslogic.com.tw, HL.Liu@...esyslogic.com.tw, 
	Greg.tu@...esyslogic.com.tw, dlunev@...omium.org, 
	Ben Chuang <ben.chuang@...esyslogic.com.tw>, 
	AKASHI Takahiro <takahiro.akashi@...aro.org>, Victor Shih <victor.shih@...esyslogic.com.tw>
Subject: Re: [PATCH V23 03/16] mmc: sdhci: add UHS-II module and add a kernel configuration

On Tue, Oct 29, 2024 at 9:56 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Victor,
>
> On Fri, Oct 18, 2024 at 1:14 PM Victor Shih <victorshihgli@...il.com> wrote:
> > From: Victor Shih <victor.shih@...esyslogic.com.tw>
> >
> > This patch adds sdhci-uhs2.c as a module for UHS-II support.
> > This is a skeleton for further development in this patch series.
> >
> > This kernel configuration, CONFIG_MMC_SDHCI_UHS2, will be used
> > in the following commits to indicate UHS-II specific code in sdhci
> > controllers.
> >
> > Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>
> > Signed-off-by: Victor Shih <victor.shih@...esyslogic.com.tw>
>
> Thanks for your patch, which is now commit 2af7dd8b64f2fd6a ("mmc:
> sdhci: add UHS-II module and add a kernel configuration") in
> linux-next/master mmc/next next-20241025 next-20241028 next-20241029
>
> > --- /dev/null
> > +++ b/drivers/mmc/host/sdhci-uhs2.c
> > @@ -0,0 +1,41 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + *  linux/drivers/mmc/host/sdhci_uhs2.c - Secure Digital Host Controller
> > + *  Interface driver
> > + *
> > + *  Copyright (C) 2014 Intel Corp, All Rights Reserved.
> > + *  Copyright (C) 2020 Genesys Logic, Inc.
> > + *  Authors: Ben Chuang <ben.chuang@...esyslogic.com.tw>
> > + *  Copyright (C) 2020 Linaro Limited
> > + *  Author: AKASHI Takahiro <takahiro.akashi@...aro.org>
>
> That is a very extensive copyright header, for just a small piece of
> boilerplate code?
>

Hi, Geert

As I know, the copyright is for the complete sdhci-uhs2.c file
and subsequent patches added the code into the sdhci-uhs2.c file.

Thanks, Victor Shih

> > + */
> > +
> > +#include <linux/module.h>
> > +
> > +#include "sdhci.h"
> > +#include "sdhci-uhs2.h"
> > +
> > +#define DRIVER_NAME "sdhci_uhs2"
> > +#define DBG(f, x...) \
> > +       pr_debug(DRIVER_NAME " [%s()]: " f, __func__, ## x)
> > +
> > +/*****************************************************************************\
> > + *                                                                           *
> > + * Driver init/exit                                                          *
> > + *                                                                           *
> > +\*****************************************************************************/
> > +
> > +static int __init sdhci_uhs2_mod_init(void)
> > +{
> > +       return 0;
> > +}
> > +module_init(sdhci_uhs2_mod_init);
> > +
> > +static void __exit sdhci_uhs2_mod_exit(void)
> > +{
> > +}
> > +module_exit(sdhci_uhs2_mod_exit);
> > +
> > +MODULE_AUTHOR("Intel, Genesys Logic, Linaro");
> > +MODULE_DESCRIPTION("MMC UHS-II Support");
> > +MODULE_LICENSE("GPL");
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds