linux-kernel - Re: [PATCH v2 1/2] hung_task: add detect count for hung tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241101114833.8377-1-ioworker0@gmail.com>
Date: Fri,  1 Nov 2024 19:48:33 +0800
From: Lance Yang <ioworker0@...il.com>
To: akpm@...ux-foundation.org
Cc: ioworker0@...il.com,
	21cnbao@...il.com,
	baolin.wang@...ux.alibaba.com,
	cunhuang@...cent.com,
	david@...hat.com,
	dj456119@...il.com,
	j.granados@...sung.com,
	joel.granados@...nel.org,
	jsiddle@...hat.com,
	kent.overstreet@...ux.dev,
	leonylgao@...cent.com,
	libang.li@...group.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	linux@...ssschuh.net,
	mingzhe.yang@...com,
	ryan.roberts@....com,
	ziy@...dia.com
Subject: Re: [PATCH v2 1/2] hung_task: add detect count for hung tasks

Hi Andrew,

Sorry, I made a stupid mistake :(

sysctl_hung_task_detect_count is defined as an unsigned long, so we need
to use proc_doulongvec_minmax instead of proc_dointvec to handle it
correctly. Could you please fold the following changes into this patch?

---
 kernel/hung_task.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 229ff3d4e501..c18717189f32 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -330,7 +330,7 @@ static struct ctl_table hung_task_sysctls[] = {
 		.data		= &sysctl_hung_task_detect_count,
 		.maxlen		= sizeof(unsigned long),
 		.mode		= 0444,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_doulongvec_minmax,
 	},
 };
 
-- 

Thanks,
Lance