linux-kernel - Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173042404301.889048.6986869139957882077.robh@kernel.org>
Date: Thu, 31 Oct 2024 20:20:43 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Amit Sunil Dhamne <amitsd@...gle.com>
Cc: linux@...ck-us.net, gregkh@...uxfoundation.org, 
 linux-kernel@...r.kernel.org, kyletso@...gle.com, 
 heikki.krogerus@...ux.intel.com, krzk+dt@...nel.org, 
 dmitry.baryshkov@...aro.org, conor+dt@...nel.org, badhri@...gle.com, 
 xu.yang_2@....com, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, 
 rdbabiera@...gle.com
Subject: Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add
 usage of sink bc12 time property


On Thu, 31 Oct 2024 16:59:53 -0700, Amit Sunil Dhamne wrote:
> Add usage of "sink-bc12-completion-time-ms"  connector property to
> max33359 controller for delaying PD negotiation till BC1.2 detection
> completes. This overcomes the occasional delays observed while
> receiving PD messages where BC1.2 detection runs in parallel.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@...gle.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri@...gle.com>
> ---
>  Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: maxtcpc@25: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected)
	from schema $id: http://devicetree.org/schemas/usb/maxim,max33359.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected)
	from schema $id: http://devicetree.org/schemas/connector/usb-connector.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241031235957.1261244-3-amitsd@google.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.