linux-kernel - Re: [PATCH v2] params: Annotate struct module_param_attrs with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyTI3NoFY7uGfTWo@smile.fi.intel.com>
Date: Fri, 1 Nov 2024 14:26:04 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: kees@...nel.org, gustavoars@...nel.org, mcgrof@...nel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] params: Annotate struct module_param_attrs with
 __counted_by()

On Fri, Aug 23, 2024 at 04:59:33PM +0200, Thorsten Blum wrote:
> Add the __counted_by compiler attribute to the flexible array member
> attrs to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
> 
> Increment num before adding a new param_attribute to the attrs array and
> adjust the array index accordingly. Increment num immediately after the
> first reallocation such that the reallocation for the NULL terminator
> only needs to add 1 (instead of 2) to mk->mp->num.
> 
> Use struct_size() instead of manually calculating the size for the
> reallocation.
> 
> Use krealloc_array() for the additional NULL terminator.

What is / was the resolution on this change? It seems it either fell in cracks
or being abandoned.

-- 
With Best Regards,
Andy Shevchenko